Tim Armstrong has posted comments on this change. Change subject: IMPALA-5173: crash with hash join feeding directly into nlj ......................................................................
Patch Set 3: Code-Review+2 (1 comment) Carry +2 http://gerrit.cloudera.org:8080/#/c/6568/2/be/src/exec/nested-loop-join-builder.cc File be/src/exec/nested-loop-join-builder.cc: Line 55: // accounting, so also copy data in that cases to avoid stealing reservation > Yeah, let's update the comment to be less contradictory. Done -- To view, visit http://gerrit.cloudera.org:8080/6568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c04952e591d17e5ff7e994884be4c4c899ae192 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
