Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5173: crash with hash join feeding directly into nlj ......................................................................
IMPALA-5173: crash with hash join feeding directly into nlj The background for this bug is that we can't transfer ownership of BufferdBlockMgr::Blocks that are attached to RowBatches. The NestedLoopJoinNode accumulates row batches on its right side and tries to take ownership of the memory, which doesn't work as expected in this case. The fix is to copy the data when we encounter one of these (likely very rare) cases. Testing: Added a regression test that produces a crash before the fix and succeeds after the fix. Change-Id: I0c04952e591d17e5ff7e994884be4c4c899ae192 Reviewed-on: http://gerrit.cloudera.org:8080/6568 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/exec/nested-loop-join-builder.cc M testdata/workloads/functional-query/queries/QueryTest/spilling.test 2 files changed, 44 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c04952e591d17e5ff7e994884be4c4c899ae192 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]>
