Lars Volker has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools_scm ......................................................................
Patch Set 1: > Weird, I don't have this package at all, and things still work for > me. But I guess it's common enough elsewhere that we have to pin > it. :-( > > I don't think the binary file needs to be added, does it? We don't > do that today for any other package: > > https://github.com/apache/incubator-impala/tree/master/infra/python/deps Thanks for having a look. I believe the package was a transitive dependency. In the meantime, the upstream author has released a new version (1.15.4), so even without this change things should be back to normal. Do we still want to pin this dependency, or should we abandon this change? -- To view, visit http://gerrit.cloudera.org:8080/6599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I398972d2cdf3acc9d5d8c598fc5b964b7241f1d2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: No
