David Knupp has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools_scm ......................................................................
Patch Set 1: > Do we still want to pin this dependency, or should we abandon this change? My opinion is that pinning dependencies to specific versions is generally a good practice. We've seen breakages from unpinned versions in other packages as well. -- To view, visit http://gerrit.cloudera.org:8080/6599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I398972d2cdf3acc9d5d8c598fc5b964b7241f1d2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: No
