Attila Jeges has posted comments on this change. Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet ......................................................................
Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/5939/6/fe/src/main/java/org/apache/impala/analysis/BaseTableRef.java File fe/src/main/java/org/apache/impala/analysis/BaseTableRef.java: Line 113: "Invalid time zone in the '%s' table property: %s", > double 'the' Done http://gerrit.cloudera.org:8080/#/c/5939/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: Line 665: > Let's move all the CREATE/ALTER tests into a separate TestParquetMrInt96Wri Done Line 1882: "' '", "URI path cannot be empty."); > easier to read single quotes Done Line 1904: type == PrimitiveType.VARCHAR) { > easier to read single quotes Done http://gerrit.cloudera.org:8080/#/c/5939/6/tests/custom_cluster/test_hive_parquet_timestamp_conversion.py File tests/custom_cluster/test_hive_parquet_timestamp_conversion.py: Line 105: parquet_path = get_fs_path( > What does "fn" stand for? I'm thinking "file name", but this is not just a Renamed it to 'parquet_path' Line 123: ON i.id = h.id AND i.day = h.day -- serves as a unique key > easier to read with the alias 'i' next to the table Done Line 125: (h.timestamp_col IS NULL) != (i.timestamp_col IS NULL) > simplify the first two conditions with: Done. Had to put round brackets around col IS NULL expressions to avoid analysis errors. http://gerrit.cloudera.org:8080/#/c/5939/6/tests/query_test/test_parquet_timestamp_compatibility.py File tests/query_test/test_parquet_timestamp_compatibility.py: Line 78: def test_invalid_parquet_mr_write_zone(self, vector, unique_database): > test_invalid_parquet_mr_write_zone Done Line 118: # tz_name conversion on the timestamp values. > extra space after "triggers" Done -- To view, visit http://gerrit.cloudera.org:8080/5939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f24525ef45a2814f476bdee76655b30081079d6 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Zoltan Ivanfi <zi+ger...@cloudera.com> Gerrit-HasComments: Yes
