Tim Armstrong has posted comments on this change. Change subject: IMPALA-5186: Handle failed CreateAndOpenScanner() in MT scan. ......................................................................
Patch Set 1: Is HdfsScanner::Close() meant to be idempotent? If not, is it reasonable to add a DCHECK that would detect this error more directly. It seems like this is a kind of bug should be easy to detect if we clean up after ourselves, e.g. set invalid pointers to NULL or use smart pointers. If this isn't easy to do this seems fine but it would be nice to prevent a reoccurrence of a similar bug. -- To view, visit http://gerrit.cloudera.org:8080/6618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I777c9b8ef2eb5b556c9b145d231c543b3b8ae270 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
