Alex Behm has posted comments on this change. Change subject: IMPALA-5186: Handle failed CreateAndOpenScanner() in MT scan. ......................................................................
Patch Set 1: I added an is_closed_ flag and DCHECK to make sure Close() is only called once. Instead, I could check is_closed_ and return if you think that is preferable. I prefer the DCHECK because there is only one thread working on a scanner, and I don't see a compelling reason to support an idempotent Close() (why support a stronger guarantee than necessary?) Please take another quick look. -- To view, visit http://gerrit.cloudera.org:8080/6618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I777c9b8ef2eb5b556c9b145d231c543b3b8ae270 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
