Tim Armstrong has posted comments on this change. Change subject: IMPALA-2800: make memory maintenance less aggressive ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6626/2/be/src/common/init.cc File be/src/common/init.cc: Line 95: static const float TCMALLOC_MAX_FREE_MEMORY_FRACTION = 0.1f; > Is this reduction empirically determined? Good question - I pretty much pulled it out of thin air. Empirically it doesn't really matter because TCMalloc changed it's behaviour in version 2.4 to free large memory allocations more aggressively. -- To view, visit http://gerrit.cloudera.org:8080/6626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
