Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5186: Handle failed CreateAndOpenScanner() in MT scan. ......................................................................
IMPALA-5186: Handle failed CreateAndOpenScanner() in MT scan. The bug was that a failed CreateAndOpenScanner() could cause a scanner to be closed twice leading to freed memory being accessed. The fix is straightforward. Testing: - I cleaned up test_failpoints.py and added an MT_DOP test dimension to cover this bug. - Core tests passed. Change-Id: I777c9b8ef2eb5b556c9b145d231c543b3b8ae270 Reviewed-on: http://gerrit.cloudera.org:8080/6618 Reviewed-by: Alex Behm <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/exec/base-sequence-scanner.cc M be/src/exec/hdfs-parquet-scanner.cc M be/src/exec/hdfs-scan-node-base.cc M be/src/exec/hdfs-scan-node-base.h M be/src/exec/hdfs-scan-node-mt.cc M be/src/exec/hdfs-scanner.cc M be/src/exec/hdfs-scanner.h M be/src/exec/hdfs-text-scanner.cc M tests/failure/test_failpoints.py 9 files changed, 72 insertions(+), 67 deletions(-) Approvals: Impala Public Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I777c9b8ef2eb5b556c9b145d231c543b3b8ae270 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
