Lars Volker has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution ......................................................................
Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/6628/1/be/src/scheduling/scheduler-test.cc File be/src/scheduling/scheduler-test.cc: Line 59: cluster.AddHost(true, true, true); > Agree, this isn't pretty. Using a builder may not work well with AddHost(). Cool, thanks! http://gerrit.cloudera.org:8080/#/c/6628/1/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: Line 204: new_backend_config->AddBackend(be_desc); > You want me to remove the punctuation? I think it needs a comma after 'executor'. My first comment should have been more clear, sorry for that. :) Line 205: current_membership_.insert(make_pair(item.key, be_desc)); > Made the fields required, so I guess it's not needed now. They still are marked "optional" in StatestoreService.thrift. Am I missing something? I agree that making them "required" is a good idea. http://gerrit.cloudera.org:8080/#/c/6628/2/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 271: rapidjson::Document* document); I can't find the forward declaration. How does this compile now? Is this included transitively from somewhere else? http://gerrit.cloudera.org:8080/#/c/6628/2/be/src/util/webserver.cc File be/src/util/webserver.cc: Line 200: if (env->impala_server()->IsExecutor()) mode_str << " Executor"; nit: this used to have a comma between them in the previous PS. The other place where you output this has a "/" in between. Can we unify them? http://gerrit.cloudera.org:8080/#/c/6628/1/common/thrift/StatestoreService.thrift File common/thrift/StatestoreService.thrift: Line 65: // The address of the debug HTTP server > I added those as optional because they aren't always set (e.g. during sched I agree, making them required looks better to me, too. It removes ambiguity while requiring more space. http://gerrit.cloudera.org:8080/#/c/6628/2/common/thrift/StatestoreService.thrift File common/thrift/StatestoreService.thrift: Line 69: 6: optional bool secure_webserver; Maybe it'd be beneficial to add an optional flag "is_secured" to TNetworkAddress? This looks like other services should need the same annotation. -- To view, visit http://gerrit.cloudera.org:8080/6628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d2ff7f341c9d2b0649e4d14561077e166ad7c4d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
