Henry Robinson has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution ......................................................................
Patch Set 4: (3 comments) Just some minor comments. http://gerrit.cloudera.org:8080/#/c/6628/4/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 388: void ImpalaServer::BackendsUrlCallback( I think this should go in impala-http-handler.cc http://gerrit.cloudera.org:8080/#/c/6628/4/be/src/service/impala-server.h File be/src/service/impala-server.h: PS4, Line 284: GetServerRole Why deal with the presentation (i.e. string formatting) here, rather than let the template do the work? That is, just have the json store IsExecutor() and IsCoordinator(), and then present them how it likes. http://gerrit.cloudera.org:8080/#/c/6628/4/bin/start-impala-cluster.py File bin/start-impala-cluster.py: PS4, Line 42: \ don't think you need these inside ( ) -- To view, visit http://gerrit.cloudera.org:8080/6628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d2ff7f341c9d2b0649e4d14561077e166ad7c4d Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
