Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client ......................................................................
Patch Set 4: > (1 comment) I ran the tests and there were a few failures. I looked into the reasons and it seems like our mechanism for passing around error messages is even more complicated than I initially thought. We have an error_log, which is different from error messages, which is different from error details. There is a lot of overlap between these which results in quite some confusion. The error_log is populated when we call LogError(). The error message is the error associated with a status error. The error details are extra error messages that we attach to a status. Cumulatively, all tests together end up relying on all 3 of these being returned. Before this patch, the error_log was never being printed, but due to the overlap with the error message from the status, all the tests passed. Now, that we print the error_log with this patch, a lot of errors get printed twice, which looks ugly. I've updated the patch to take care of this. I'm running another private test to make sure all the tests pass before I put the next patchset out. -- To view, visit http://gerrit.cloudera.org:8080/6627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d9d63610eb0d2acae3a9303ce46e1410727ce87 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
