Dan Hecht has posted comments on this change.

Change subject: IMPALA-5198: Error messages are sometimes dropped before 
reaching client
......................................................................


Patch Set 7:

Thanks, this is much nicer.

Could you make sure we have a regression test for IMP-633 (there was no test 
with that commit), and if not, add one? We should make sure that that problem 
really was also solved by including the query_status explicitly in get_log().

-- 
To view, visit http://gerrit.cloudera.org:8080/6627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d9d63610eb0d2acae3a9303ce46e1410727ce87
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to