Tim Armstrong has posted comments on this change. Change subject: IMPALA-5192: Don't bake MemPool* into IR ......................................................................
Patch Set 2: Code-Review+1 (4 comments) This looks good to me aside from some comments that need updating. http://gerrit.cloudera.org:8080/#/c/6657/2/be/src/codegen/codegen-anyval.h File be/src/codegen/codegen-anyval.h: Line 200: /// If 'pool_val' is non-NULL, var-len data will be copied into 'pool_val'. We should explain that pool_val needs to be a MemPool* Line 208: /// If 'pool_val' is non-NULL, var-len data will be copied into 'pool_val'. Same here Line 224: llvm::Value* pool_val, llvm::BasicBlock* insert_before = nullptr); And here http://gerrit.cloudera.org:8080/#/c/6657/2/be/src/runtime/tuple.h File be/src/runtime/tuple.h: Line 165: /// 'pool' may be NULL, in which case no pool-related code is generated. Otherwise Comment needs updating. -- To view, visit http://gerrit.cloudera.org:8080/6657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09d620e48032351ab9805825a4afb6536bed2302 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
