Michael Ho has posted comments on this change. Change subject: IMPALA-5192: Don't bake MemPool* into IR ......................................................................
Patch Set 3: (4 comments) Will post new patch after https://gerrit.cloudera.org/#/c/6459/ is merged. http://gerrit.cloudera.org:8080/#/c/6657/3/be/src/codegen/codegen-anyval.cc File be/src/codegen/codegen-anyval.cc: PS3, Line 528: CodegenAllocate > okay to ignore, but I think this would be clearer if called CodegenMemPoolA Done http://gerrit.cloudera.org:8080/#/c/6657/3/be/src/runtime/tuple.cc File be/src/runtime/tuple.cc: PS3, Line 344: // Value* non_null_string_values_arg = args[5]; // unused : // Value* total_string_lengths_arg = args[6]; // unused : // Value* num_non_null_string_values_arg = args[7]; // unused > what does this mean? that these out-parameters can't be used with codegen? This function makes an assumption that 'collect_string_vals' is false so these arguments are not used. Added some comments for it. http://gerrit.cloudera.org:8080/#/c/6657/3/be/src/runtime/tuple.h File be/src/runtime/tuple.h: PS3, Line 121: . > it would probably be good to mention the equivalent thing about codegen -- Done PS3, Line 167: There are two different MaterializeExprs symbols to differentiate between : /// these cases when we replace the function calls during codegen. > what is this referring to exactly? we generate two versions of the same fun Please see Tuple::MATERIALIZE_EXPRS_SYMBOL and Tuple::MATERIALIZE_EXPRS_NULL_POOL_SYMBOL. Comments updated to refer to the comment of MaterializeExprs() about the two different symbols. -- To view, visit http://gerrit.cloudera.org:8080/6657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09d620e48032351ab9805825a4afb6536bed2302 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
