Dan Hecht has posted comments on this change. Change subject: IMPALA-5220: memory maintenance cleanup ......................................................................
Patch Set 5: (2 comments) Nice! http://gerrit.cloudera.org:8080/#/c/6626/5//COMMIT_MSG Commit Message: Line 25: by the gperftools 2.4 upgrade). that doesn't seem like a valid conclusion given that MemTracker::Release() also forced the unmapping of tc-malloc heap. Line 29: was generally sensible. I assume you reran this after the test? Did you happen to peak at RSS to in the stress result to see that goes down when the test is idle? -- To view, visit http://gerrit.cloudera.org:8080/6626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
