Dan Hecht has posted comments on this change. Change subject: IMPALA-5220: memory maintenance cleanup ......................................................................
Patch Set 6: > (2 comments) > > The consumption metric refresh shouldn't be consequential. It > previously was controlled by logbufsec, which defaulted to 5s. Also > if there are queries actually running and checking memory > consumption they'll force refresh of the metric, this mainly just > exists to prevent it getting permanently out of sync while the > system is idle. I agree we don't want to rely on this, but just wanted to make sure we don't. i.e. the fix wouldn't be to change the frequency here, but to make sure admission control updates consumption before using it. Anyway, I think admission control only looks at pool memtrackers, not the process tracker, but I'm not positive. -- To view, visit http://gerrit.cloudera.org:8080/6626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: No
