Tim Armstrong has posted comments on this change. Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2 ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6638/2/be/src/runtime/buffered-tuple-stream-v2.h File be/src/runtime/buffered-tuple-stream-v2.h: Line 269: /// Use boost::function instead of std::function because it is better at avoiding heap > What about using a template? I couldn't find a cleaner way to do this. The template solution works if all the functions are inline in the header, but in this case we end up instantiating the function object anyway to call into AllocateSlow(). The other alternative that had reasonable runtime behaviour was the c-style function pointer + void* pointer combo, but that was clunky in the calling code. -- To view, visit http://gerrit.cloudera.org:8080/6638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2861c58efa7bc1aeaa5b7e2f043c97cb3985c8f5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
