Tim Armstrong has posted comments on this change. Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2 ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6638/2/be/src/runtime/buffered-tuple-stream-v2.h File be/src/runtime/buffered-tuple-stream-v2.h: Line 269: /// Use boost::function instead of std::function because it is better at avoiding heap > Not following you 100% - AllocateSlow could also be a templated method, lik My concern there was that either we have to put AllocateRowSlow() in a header and bloat our code unnecessarily, or put it in a .cc and somehow figure out how to instantiate it with whatever internal types our lambdas have. I didn't like either option too much. I think this solution should work out ok - if it's a perf issue (which I haven't seen so far in testing it, but haven't heavily tested it) I can revert to using a function pointer. -- To view, visit http://gerrit.cloudera.org:8080/6638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2861c58efa7bc1aeaa5b7e2f043c97cb3985c8f5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
