Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client ......................................................................
IMPALA-5198: Error messages are sometimes dropped before reaching client The Status::ToThrift() function takes the ErrorMsg, and pushes both the msg() and details() into the TStatus::error_msgs list. However, when we unpack the TStatus object into a Status object, we just copy all the TStatus::error_msgs to Status::ErrorMsg::details_ and leave Status::ErrorMsg::message_ blank. This led to the error message not being printed in certain cases which is now fixed. The PlanFragmentExecutor had some code to add query statuses to the error_log (IMP-633), which is no longer necessary after a future patch (IMPALA-762) explicitly returned the query status to the client via get_log(), making the adding of the query statuses to the error_log redundant. That code in the PFE has been removed and a test has been added to make sure that the case it previously tried to fix doesn't regress. Change-Id: I5d9d63610eb0d2acae3a9303ce46e1410727ce87 Reviewed-on: http://gerrit.cloudera.org:8080/6627 Reviewed-by: Sailesh Mukil <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/common/status.cc M be/src/common/status.h M be/src/runtime/plan-fragment-executor.cc M be/src/util/error-util.h M tests/data_errors/test_data_errors.py 5 files changed, 51 insertions(+), 20 deletions(-) Approvals: Impala Public Jenkins: Verified Sailesh Mukil: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d9d63610eb0d2acae3a9303ce46e1410727ce87 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
