Tim Armstrong has posted comments on this change.

Change subject: Ported native-toolchain to work on ppc64le
......................................................................


Patch Set 1:

(1 comment)

Thanks for the responses - looking forward to the next patchset. I missed that 
you were waiting for a comment to push the next patchset - usually I wait until 
a new patchset has been pushed to do the next review pass.

http://gerrit.cloudera.org:8080/#/c/6468/1/source/crcutil/build.sh
File source/crcutil/build.sh:

Line 42:   wrap autoreconf -i;
> Patching mechanism usage for 2nd patch file. Please let me know your views 
Shouldn't you patch Makefile.in then so that the generated Makefile.am is 
correct?


-- 
To view, visit http://gerrit.cloudera.org:8080/6468
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Valencia Edna Serrao <vser...@us.ibm.com>
Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Valencia Edna Serrao <vser...@us.ibm.com>
Gerrit-HasComments: Yes

Reply via email to