Jim Apple has posted comments on this change.

Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating 
impala tables.
......................................................................


Patch Set 2:

(2 comments)

I'm going to add a review, since Lars is AFK and I am not very familiar with 
Parquet.

http://gerrit.cloudera.org:8080/#/c/6550/2/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test
File 
testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test:

Line 57: '$FILESYSTEM_PREFIX/test-warehouse/schemas/logicaltypes.parquet'
Please indicate here what the logic types in question are.


Line 66: STRING, STRING, STRING
You'll also want to see that SELECT works, I think.


-- 
To view, visit http://gerrit.cloudera.org:8080/6550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a2e20c3ab83eb3fac422c3b33c117856fec475
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jakub Kukul <[email protected]>
Gerrit-Reviewer: Jakub Kukul <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-HasComments: Yes

Reply via email to