Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables. ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6550/3/docs/topics/impala_parquet.xml File docs/topics/impala_parquet.xml: PS3, Line 1154: ENUM Are enums logical types? For some reason they are not documented here https://github.com/Parquet/parquet-format/blob/master/LogicalTypes.md http://gerrit.cloudera.org:8080/#/c/6550/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeFileStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeFileStmt.java: Line 274: // UTF8 is the type annotation Parquet uses for strings This comment needs to be updated. It would be good if you put a link to a some document that states that Binary + Enum = string http://gerrit.cloudera.org:8080/#/c/6550/3/testdata/data/schemas/logicaltypes.parquet File testdata/data/schemas/logicaltypes.parquet: How did you generate this file? Was it with Hive? -- To view, visit http://gerrit.cloudera.org:8080/6550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7a2e20c3ab83eb3fac422c3b33c117856fec475 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jakub Kukul <[email protected]> Gerrit-Reviewer: Jakub Kukul <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
