Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5192: Don't bake MemPool* into IR ......................................................................
IMPALA-5192: Don't bake MemPool* into IR Tuple::CodegenMaterializeExprs() currently bakes the MemPool* provided by its caller into the generated IR. The MemPool* usually belongs to some exec nodes which owns the codegend function and it's used for allocating string buffer. With multi-threading, IR needs to be shared across multiple fragment instances so IR can no longer contain pointers not shared across fragment instances. This change fixes the problem above by using the MemPool* argument passed to the IR function. This also cleans up UnionNode by removing the field tuple_pool_ from it and the logic for transferring buffer from tuple_pool_ to the MemPool of the row batch. Change-Id: I09d620e48032351ab9805825a4afb6536bed2302 Reviewed-on: http://gerrit.cloudera.org:8080/6657 Reviewed-by: Michael Ho <k...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/codegen/codegen-anyval.cc M be/src/codegen/codegen-anyval.h M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/topn-node-ir.cc M be/src/exec/topn-node.cc M be/src/exec/union-node-ir.cc M be/src/exec/union-node.cc M be/src/exec/union-node.h M be/src/runtime/tuple.cc M be/src/runtime/tuple.h 11 files changed, 107 insertions(+), 121 deletions(-) Approvals: Impala Public Jenkins: Verified Michael Ho: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09d620e48032351ab9805825a4afb6536bed2302 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
