Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals() ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6610/6/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: Line 678: for (SlotDescriptor* slot: slots()) sorted_slots[slot->slot_idx_] = slot; It turns out that the reason why the GVO for this patch is failing is that slot_idx does not always start with 0. The following query produces a tuple with a single slot with a slot_idx=1: select c_custkey, v1.cnt from tpch_nested_parquet.customer c inner join (select count(*) cnt from c.c_orders where false) v1 where c_custkey < 10 The tuple looks like this: Tuple(id=0 size=25 slots=[Slot(id=3 type=BIGINT col_path=[0] offset=16 null=(offset=24 mask=2) slot_idx=1 field_idx=-1)] tuple_path=[]) -- To view, visit http://gerrit.cloudera.org:8080/6610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I426ad244678dbfe517262dfb7bbf4adc0247a35e Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
