Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals() ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6610/7/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: Line 529: } > let's verify (DCHECK) that all tuples are dense at this point. After implementing this DCHECK, it turns out we hit it quite often. The reason is we sometimes send materialized tuples without a mem layout to the BE (which are basically unusable) eg, when replacing plan trees with an EmptySetNode. There is a TODO in DescriptorTable.toThrift() regarding this. -- To view, visit http://gerrit.cloudera.org:8080/6610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I426ad244678dbfe517262dfb7bbf4adc0247a35e Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
