Alex Behm has posted comments on this change. Change subject: IMPALA-5162,IMPALA-5163: stress test support on secure clusters ......................................................................
Patch Set 1: (2 comments) Changes look reasonable, but I'm not super familiar with this code. http://gerrit.cloudera.org:8080/#/c/6763/1/tests/comparison/cluster.py File tests/comparison/cluster.py: Line 364: "0.0.0.0:50070") Independent question: Does it even make sense to plug in default values here? Seems like a misconfiguration might be hard to debug if we plug in default values, instead of throwing an error. Line 412: local_shell(pip_path + " install pykerberos==1.1.14 requests-kerberos==0.11.0", Not your change, but this flow strikes me as odd. We have packages+versions baked into the code here. What's the benefit of doing this lazy install+import as opposed to requiring these to be installed up-front? -- To view, visit http://gerrit.cloudera.org:8080/6763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0daad57bb8ceeb5071b75125f11c1997ed7e0179 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Matthew Mulder <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-HasComments: Yes
