Alex Behm has posted comments on this change.

Change subject: IMPALA-5162,IMPALA-5163: stress test support on secure clusters
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6763/1/tests/comparison/cluster.py
File tests/comparison/cluster.py:

Line 364:                                               "0.0.0.0:50070")
> I can only speculate: My guess it has to do with supporting Mini vs. real c
Let's not make the changes in this patch to avoid breaking functionality. Just 
wanted to get your take on this pattern.


Line 412:           local_shell(pip_path + " install pykerberos==1.1.14 
requests-kerberos==0.11.0",
> I can only speculate: I've seen this pattern in a few places and it's likel
Thanks. If you agree there is questionable/little benefit to this lazy 
install+import, we should consider simplifying it - but not in this patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/6763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0daad57bb8ceeb5071b75125f11c1997ed7e0179
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Matthew Mulder <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Mostafa Mokhtar <[email protected]>
Gerrit-HasComments: Yes

Reply via email to