Jim Apple has posted comments on this change. Change subject: IMPALA-5266 Impala ABM / LZCNT support ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5821/5/be/src/util/bit-util.h File be/src/util/bit-util.h: Line 88: return (value >> bits) | (value << (64 - bits)); > DCHECK that this isn't the case? With a comment explaining why. -- To view, visit http://gerrit.cloudera.org:8080/5821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f6a465ab4a9ee4f582847f8e211a779bdede3d2 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
