Zach Amsden has posted comments on this change. Change subject: IMPALA-5266 Impala ABM / LZCNT support ......................................................................
Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/5821/8/be/src/util/bit-util.h File be/src/util/bit-util.h: Line 323: static inline int Log2FloorNonZero(uint32_t n) { This actually ended up unused, as the 32-bit version of the RoundUpToPowerOfTwoNoHw implementation was slower than the 64-bit one! http://gerrit.cloudera.org:8080/#/c/5821/8/be/src/util/fixed-size-hash-table.h File be/src/util/fixed-size-hash-table.h: Line 53: DCHECK_EQ(capacity_, BitUtil::RoundUpToPowerOfTwo(static_cast<int64_t>(capacity_))); Uses of unsigned integers actually get caught now. -- To view, visit http://gerrit.cloudera.org:8080/5821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f6a465ab4a9ee4f582847f8e211a779bdede3d2 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
