Michael Brown has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6817/1/testdata/workloads/functional-query/queries/QueryTest/hdfs-text-scan-with-header.test File testdata/workloads/functional-query/queries/QueryTest/hdfs-text-scan-with-header.test: PS1, Line 115: drop table if exists mixed; DDL http://gerrit.cloudera.org:8080/#/c/6817/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: PS1, Line 688: Can you talk about why you removed unique_database? When I look at QueryTest/hdfs-text-scan-with-header I see DDL statements which could cause collisions. There are 4 versions of this test in exhaustive: <Module 'tests/query_test/test_scanners.py'> <Class 'TestTextScanRangeLengths'> <Instance '()'> <Function "test_text_scanner_with_header[exec_option: {'disable_codegen': True, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0, 'batch_size': 0, 'num_nodes': 0} | table_format: text/none]"> <Function "test_text_scanner_with_header[exec_option: {'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0, 'batch_size': 0, 'num_nodes': 0} | table_format: text/none]"> <Function "test_text_scanner_with_header[exec_option: {'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0, 'batch_size': 0, 'num_nodes': 0} | table_format: text/gzip/block]"> <Function "test_text_scanner_with_header[exec_option: {'disable_codegen': True, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0, 'batch_size': 0, 'num_nodes': 0} | table_format: text/gzip/block]"> -- To view, visit http://gerrit.cloudera.org:8080/6817 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f3c29a42501cfb2751f7ad0af166eb88f63b70 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
