Lars Volker has posted comments on this change. Change subject: IMPALA-5287: Test skip.header.line.count on gzip ......................................................................
Patch Set 3: (5 comments) Thanks for the comments. Please see PS4. http://gerrit.cloudera.org:8080/#/c/6817/3/testdata/data/README File testdata/data/README: PS3, Line 100: ,, > double comma Done http://gerrit.cloudera.org:8080/#/c/6817/3/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: PS3, Line 2092: '${{env:IMPALA_HOME}} > How does this differ from {impala_home} ? Specifying {impala_home} here didn't work, since it does not get replaced in DEPENDENT_LOAD sections. This is due to the somewhat convoluted way we build these. Instead, one pair of {} will be stripped by the .format() call and the result will be passed to Hive, which (I think) will then expand the variable. I added the replacement. Should we replace all other occurrences in this file in this commit? http://gerrit.cloudera.org:8080/#/c/6817/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: PS3, Line 288: replace > "replaced" Done Line 289: values in queries before they are executed. > Mention that callers need to be careful about key name choices. For example Done http://gerrit.cloudera.org:8080/#/c/6817/3/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: PS3, Line 685: cls.ImpalaTestMatrix.add_constraint(lambda v:\ : v.get_value('table_format').file_format == 'text' and\ > The backslashes are not needed. Fixed here and elsewhere. -- To view, visit http://gerrit.cloudera.org:8080/6817 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f3c29a42501cfb2751f7ad0af166eb88f63b70 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
