Dan Hecht has posted comments on this change. Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6707/2//COMMIT_MSG Commit Message: Line 22: - As an exception, we don't grab QES::lock_ while the query planning is > Not much success on this front. I'm not able to repro the scenario via test Load isn't relevant. The lock dependency is the problem, so as long as you hold the map lock, you should be able to demonstrate the problem. Just to be clear, you tried to reproduce this using the test but without the fixes, right? http://gerrit.cloudera.org:8080/#/c/6707/3/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS3, Line 603: // For queries in CREATED state, the profile information isn't populated yet. : if (exec_state->query_state() == beeswax::QueryState::CREATED) return Status::OK(); > Wanted to double check if this change is required. Reason being, with this Is it possible to get to this method for a query that hasn't returned from ExecStatement() yet? Where does the query_id come from along the paths that call into here? Also, what info is in the profile up to this point? -- To view, visit http://gerrit.cloudera.org:8080/6707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie44daa93e3ae4d04d091261f3ec4891caffe8026 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
