Dan Hecht has posted comments on this change. Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6707/6//COMMIT_MSG Commit Message: PS6, Line 16: While the actual fix for this is to not hold the QES::lock_ during : metadata load, I disagree. what you are doing is the actual fix for the lock acquisition order. Not holding QES::lock_ while planning is a partial fix for a different issue (not being able to cancel while planning). PS6, Line 20: We make sure that QES::lock_ doesn't block query_exec_state_map_lock_ : in hot paths. After this change, isn't it the case that we'll never try to acquire another lock while holding the map lock? If so, this should say make query_exec_state_map_lock_ a terminal lock. -- To view, visit http://gerrit.cloudera.org:8080/6707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie44daa93e3ae4d04d091261f3ec4891caffe8026 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
