Dan Hecht has posted comments on this change. Change subject: IMPALA-5238: transfer reservations between trackers ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6708/7/be/src/runtime/bufferpool/reservation-tracker.cc File be/src/runtime/bufferpool/reservation-tracker.cc: PS7, Line 306: in this case, path_to_root did make sense. maybe your search/replace was too aggressive. http://gerrit.cloudera.org:8080/#/c/6708/6/be/src/runtime/bufferpool/reservation-tracker.h File be/src/runtime/bufferpool/reservation-tracker.h: PS6, Line 232: subtrees > Right, before the lock order was only a partial order - if neither tracker Yup, got that from the new comment which is clearer. I think the name is still misleading because it seems to imply the lock order for any two subtrees, whereas this ordering is just for sibling subtrees. So how about: lock_sibling_subtree_first()? -- To view, visit http://gerrit.cloudera.org:8080/6708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21f008abaf1aa4fcd2d854769a603b97589af3b3 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
