Dan Hecht has posted comments on this change. Change subject: IMPALA-5238: transfer reservations between trackers ......................................................................
Patch Set 8: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6708/8/be/src/runtime/bufferpool/reservation-tracker.cc File be/src/runtime/bufferpool/reservation-tracker.cc: Line 195: void ReservationTracker::ReleaseToMemTracker(int64_t reservation_decrease) { let's add: DCHECK_GE(reservation_decrease, 0); and likewise in TryConsumeFrom.. it's probably easy to think the same value should be passed in here as UpdateReservation() but it's actually the negative. Line 219: parent_->DecreaseReservation(bytes, true); could restore that back to one line -- To view, visit http://gerrit.cloudera.org:8080/6708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21f008abaf1aa4fcd2d854769a603b97589af3b3 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
