Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/6792/5/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: Line 403: std::vector<std::string> sorted_master_addresses(master_addresses); no std:: in .cc Line 404: sort(sorted_master_addresses.begin(), sorted_master_addresses.end()); do we need this/do we really need to worry about getting asked for a client for the same addresses but in different order? http://gerrit.cloudera.org:8080/#/c/6792/5/fe/src/main/java/org/apache/impala/util/KuduUtil.java File fe/src/main/java/org/apache/impala/util/KuduUtil.java: Line 72: private static Map<String, KuduClient> kuduClients = Maps.newHashMap(); move above the function comment. follow formatting rules for member variables. add comment. -- To view, visit http://gerrit.cloudera.org:8080/6792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b0c12a256c33e8ef32315b3736cae2dea2ae705 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
