Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created ......................................................................
Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/6792/1//COMMIT_MSG Commit Message: Line 22: > did your manual testing involve concurrency? I think it's still an area for Done http://gerrit.cloudera.org:8080/#/c/6792/2/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: Line 80: sink_action_(tsink.table_sink.action), > move to the header Done PS2, Line 83: } : : Status KuduTableSink::PrepareExp > can you set these to nullptr as well in the header Done Line 145: // and the client failed to be created, it must be released. > fit on 1line? Its too long. http://gerrit.cloudera.org:8080/#/c/6792/2/be/src/exec/kudu-table-sink.h File be/src/exec/kudu-table-sink.h: PS2, Line 103: client_ > set to nullptr here Done http://gerrit.cloudera.org:8080/#/c/6792/2/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: PS2, Line 403: _addresses; > can you sort the list before joining? That way we can avoid dupes between s Done http://gerrit.cloudera.org:8080/#/c/6792/2/be/src/runtime/exec-env.h File be/src/runtime/exec-env.h: PS2, Line 193: he ExecEnv. This > this is wrong now Done PS2, Line 193: requires that the master : /// address lists be identical in order to share a KuduClient > I don't think this sentence is relevant. Remove Done -- To view, visit http://gerrit.cloudera.org:8080/6792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b0c12a256c33e8ef32315b3736cae2dea2ae705 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
