Lars Volker has posted comments on this change. Change subject: IMPALA-4764: Add Hedged read metrics ......................................................................
Patch Set 3: (2 comments) Thank you for working on this. http://gerrit.cloudera.org:8080/#/c/6886/3//COMMIT_MSG Commit Message: Line 19: Testing: Not adding tests since it requires some custom hadoop Can we add a custom cluster test, at least as a smoke test? http://gerrit.cloudera.org:8080/#/c/6886/3/be/src/util/impalad-metrics.cc File be/src/util/impalad-metrics.cc: Line 104: "impala-server.hedged-read-ops"; Have you considered grouping them under a common prefix, like impala-server.hdfs.*? I don't feel strongly about it. -- To view, visit http://gerrit.cloudera.org:8080/6886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4a5d396abb3373d352ad2df8c2272db018114da Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
