Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4764: Add Hedged read metrics ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6886/4//COMMIT_MSG Commit Message: PS4, Line 13: hedgeReadOpsWin typo http://gerrit.cloudera.org:8080/#/c/6886/3/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: PS3, Line 349: FLAGS_use_hdfs_pread > I agree, however, I did this for perf reasons. The "hdfsGetHedgedReadMetric Ok, fair enough, just mention that in a comment. -- To view, visit http://gerrit.cloudera.org:8080/6886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4a5d396abb3373d352ad2df8c2272db018114da Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
