Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5144: Remove sortby() hint ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6885/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: PS2, Line 1792: Do we have any tests that use shuffle and clustered? If not, maybe we shouldn't delete all these tests. We may want to modify some instead by removing the sortby hint. http://gerrit.cloudera.org:8080/#/c/6885/2/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java: PS2, Line 508: Since you're at it, maybe add a simply test with clustered as well. Didn't see any. http://gerrit.cloudera.org:8080/#/c/6885/2/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test File testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test: PS2, Line 328: Same comment as before. Just make sure we have some coverage for shuffle + clustering. -- To view, visit http://gerrit.cloudera.org:8080/6885 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83e1cd6fa7039035973676322deefbce00d3f594 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
