Lars Volker has posted comments on this change. Change subject: IMPALA-5144: Remove sortby() hint ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6885/3/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: PS3, Line 213: hint_with_args > I am wondering now that we removed the sort by hint if we still need this. Currently we don't need it, but when I implemented the sortby() hint, I changed the parser to properly parse hints inside comments, instead of just splitting them at ",". At the time I also added a PlanHint class, that supports hints with arguments. With this test we can make sure that that functionality doesn't deteriorate. Should we instead try and remove it altogether? -- To view, visit http://gerrit.cloudera.org:8080/6885 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83e1cd6fa7039035973676322deefbce00d3f594 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
