Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6527/2/be/src/exec/base-sequence-scanner.h File be/src/exec/base-sequence-scanner.h: Line 86: virtual Status GetNextInternal(RowBatch* row_batch); > Sounds fine - it would be good though to do the follow-on patch before comm No point in waiting then. Added WARN_UNUSED_RESULT to all scanners and the hdfs-relevant scan nodes. http://gerrit.cloudera.org:8080/#/c/6527/2/be/src/exec/hdfs-rcfile-scanner.h File be/src/exec/hdfs-rcfile-scanner.h: Line 404: uint8_t* row_group_buffer_; > I think maybe StringBuffer should be called MemoryBuffer or something like Agree about changing the name/comments of StringBuffer. Leaving as is for now, lmk if you still want to me to change it. -- To view, visit http://gerrit.cloudera.org:8080/6527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie18f57b0d3fe0052a8ccd361b6a5fcdf979d0669 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
