Tim Armstrong has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. ......................................................................
Patch Set 4: (6 comments) Did the tests pass? I did another pass over the code, just had minor comments. Thanks for making those changes. http://gerrit.cloudera.org:8080/#/c/6527/4/be/src/exec/base-sequence-scanner.cc File be/src/exec/base-sequence-scanner.cc: PS4, Line 89: static_cast<HdfsScanNodeBase*>( Is this cast needed? It looks like this is already the type of scan_node_. http://gerrit.cloudera.org:8080/#/c/6527/4/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: Line 64: using std::unique_ptr; Aren't these in common/names.h? http://gerrit.cloudera.org:8080/#/c/6527/4/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 52: using std::move; I think common/names.h has this http://gerrit.cloudera.org:8080/#/c/6527/4/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: PS4, Line 112: unique_ptr<RowBatch>( : new RowBatch make_unique<RowBatch>( ? http://gerrit.cloudera.org:8080/#/c/6527/4/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: PS4, Line 136: tow row http://gerrit.cloudera.org:8080/#/c/6527/4/be/src/exec/kudu-scan-node.cc File be/src/exec/kudu-scan-node.cc: Line 174: unique_ptr<RowBatch> row_batch(new RowBatch( make_unique? -- To view, visit http://gerrit.cloudera.org:8080/6527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie18f57b0d3fe0052a8ccd361b6a5fcdf979d0669 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
