Alex Behm has posted comments on this change. Change subject: IMPALA-5286: Query fails due to Kudu column name case ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6902/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 946: String key = slotPath.toString().toLowerCase(); > Its true that we don't convert Kudu column names to lower case when creatin The current solution is also brittle. There must surely be similar bugs lurking. I like your KuduColumn proposal because it makes those places that rely on the correct casing explicit. There are probably still more bugs, but this way the fixes are Kudu specific and very explicit about casing. -- To view, visit http://gerrit.cloudera.org:8080/6902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14aba88510012174716691b9946e1c7d54d01b44 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
