Alex Behm has posted comments on this change. Change subject: IMPALA-5286/IMPALA-5283: Kudu column name case cleanup ......................................................................
Patch Set 3: (5 comments) I actually prefer the original solution from the previous patch. Let me look at that in more detail. http://gerrit.cloudera.org:8080/#/c/6902/3/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: Line 371: // Column names in the casing that they appear in Kudu. Mention that these are in an arbitrary order http://gerrit.cloudera.org:8080/#/c/6902/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 959: key.equals(key.toLowerCase()), "Slot paths should be lower case: " + key); use StringUtils.isAllLowerCase() here and elsewhere http://gerrit.cloudera.org:8080/#/c/6902/3/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: Line 255: Set<String> colNames = Sets.newHashSet(); lowerCaseColNames Line 258: if (colNames.contains(lowerCaseColName)) { instead of the extra contains() you can check the return value of add() Line 260: String.format("Error loading Kudu table: conflicting column name '%s'", Spell out what the problem is. "Conflicting column name" is not very clear. -- To view, visit http://gerrit.cloudera.org:8080/6902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14aba88510012174716691b9946e1c7d54d01b44 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
