anujphadke has posted comments on this change. Change subject: IMPALA-5347: Parquet scanner microoptimizations ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6950/2/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: Line 426: *num_values = (curr_tuple - tuple_mem) / tuple_size; Should we add a DCHECK to make sure that tuple_size is non-zero? -- To view, visit http://gerrit.cloudera.org:8080/6950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49ec523a65542fdbabd53fbcc4a8901d769e5cd5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
