Alex Behm has posted comments on this change. Change subject: IMPALA-5347: Parquet scanner microoptimizations ......................................................................
Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/6950/4/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 979: Status HdfsParquetScanner::ResetScratchBatch() { > ScratchTupleBatch then would have to call out to HdfsScanNode::InitTuple(). Good point. The change may be an improvement, but I don't think we need to do that now. In particular, rebasing my scanner change is not going to be fun (but I'll do it if you prefer to make the change now). -- To view, visit http://gerrit.cloudera.org:8080/6950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49ec523a65542fdbabd53fbcc4a8901d769e5cd5 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
