Joe McDonnell has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache ......................................................................
Patch Set 10: (3 comments) About to post another upload. http://gerrit.cloudera.org:8080/#/c/6478/8/be/src/runtime/disk-io-mgr-handle-cache.h File be/src/runtime/disk-io-mgr-handle-cache.h: Line 88: /// is set to true. Otherwise, the partition will try to construct a file handle and > true, but you're describing a scenario with concurrent queries and updates. That makes sense. We don't provide guarantees, and it seems like an uncommon case. I will include this on the JIRA I file for the time based eviction. http://gerrit.cloudera.org:8080/#/c/6478/8/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: Line 417: } else { > so it's just num_bytes_read then. when i see 'last' or 'prev' or something That makes sense. I think this came about trying to avoid a naming collision with the function's argument "bytes_read". Since we already have bytes_read and bytes_read_, I switched this to current_bytes_read rather than num_bytes_read. http://gerrit.cloudera.org:8080/#/c/6478/10/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: Line 352: int success = hdfsGetHedgedReadMetrics(fs_, &hedged_metrics); > you're getting metrics for the whole fs_, but every scan range does that on This came in due to a rebase. IMPALA-4764 added this. I had to move it around because the code changed in Close(). It is setting the metric to this value rather than adding it. -- To view, visit http://gerrit.cloudera.org:8080/6478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5ff60971dd653c3b6a0e13928cfa9fc59d078d Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
