Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache ......................................................................
Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/6478/11/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: Line 445: // bad file handle; record the error, but allow for a retry to fix it. wouldn't the same apply to the pread path? also, wouldn't the same apply to l293? Line 467: if (current_bytes_read != -1 || num_retries >= 1 || num_retries == 1 and dcheck that it's not >1 somewhere? Line 468: (hdfs_file_from_cache == nullptr)) { remove ()? Line 471: // If the file handle is from the cache, it might have become invalid. Destroy rephrase, we know it's from the cache -- To view, visit http://gerrit.cloudera.org:8080/6478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5ff60971dd653c3b6a0e13928cfa9fc59d078d Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
